Joomdonation Feedback and notes

  • Jason Landau
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
6 years 11 months ago #96894 by Jason Landau
Joomdonation Feedback and notes was created by Jason Landau
Hi I just wanted to give some feedback and ask a little help if you're up for it.

I don't really think that using the language file for all titles is a great approach, no offense. It looks weird unless everything really has the same title.

First Idea**************
components/com_jdonation/view/campaigns/tmpl/default.php
I think it would be great if you could include the page title set by the menu. I did this which is rough...
$menu = &JSite::getMenu();
$active = $menu->getActive();
$menuname = $active->params->get('page_heading');
<h1 class="page-title"><?php echo $menuname; ?></h1>

Second Idea**********************
Same thing. Title should be the name of the campaign. You use it in the file so it was easy to find.
components/com_jdonation/view/donation/tmpl/default.php
<h1 class="jd-page-title"><?php echo $this->campaign->title ?></h1>

IMHO those would be improvements for all users and I don't really see a downside but maybe there's something I don't know.
Thank you for the great software!

Please Log in or Create an account to join the conversation.

More
6 years 11 months ago #97314 by Mr. Dam
Replied by Mr. Dam on topic Joomdonation Feedback and notes
Hi Jason,
Thank you for your idea, i will make this change for next Joom Donation version
Regards,
Dam

Please Log in or Create an account to join the conversation.

Moderators: Mr. DamDũng Nguyễn Việt