Bug in plan handling

  • Mark
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
7 years 4 months ago - 7 years 4 months ago #91027 by Mark
Bug in plan handling was created by Mark
How long a string are you handling for alias names? I suspect, for some reason, it's shorter than 23.

I have two plans with quite long names, 23 chars or longer, identical except for the 23rd character. I let the alias autogenerate

Whilst they both display correctly on the front end, trying to select one of them results in an error, OSM_INVALID_SUBSCRIPTION_PLAN to be exact (not got a string, it would seem).

When I make the first couple of characters of the alias unique, they work correctly. Strange, eh? B)
Last edit: 7 years 4 months ago by Mark.

Please Log in or Create an account to join the conversation.

More
7 years 4 months ago #91038 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Bug in plan handling
The alias is actually set to 255, so I don't know why it is set to 23 chars. The alias is generated by Joomla core library, maybe Joomla has that limit applied somewhere, I don't really know

For now, please make sure each plan has it's unique alias to have the system works well. I will check it later

Tuan
The following user(s) said Thank You: Mark

Please Log in or Create an account to join the conversation.

  • Mark
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
7 years 4 months ago #91044 by Mark
Replied by Mark on topic Bug in plan handling
Thanks Tuan, I thought you'd be using core functions.

It's not that the alias is limited to 23 characters, the alias length is fine.

What's happening, I'm certain, is that it's only checking the first 22 characters, otherwise why would it not find the second plan whose alias is the same as the first one up to the 23rd character?

Please Log in or Create an account to join the conversation.

More
7 years 4 months ago #91090 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Bug in plan handling
Hello Mark

To be honest, I don't know. There are no places in my code to only check 22 characters, so I don't really have any clues why it happens

Tuan
The following user(s) said Thank You: Mark

Please Log in or Create an account to join the conversation.

  • Mark
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
7 years 3 months ago #92815 by Mark
Replied by Mark on topic Bug in plan handling
Following on from this, it appears there is no checking to prevent identical aliases?

And having two aliases the same breaks the extension, as before.
Except, it seems to work on my local setup. The only relevant difference I can find is that my local setup doesn't use URL rewriting...

Pretty major fault, imnvho ;)

Please Log in or Create an account to join the conversation.

More
7 years 3 months ago #92827 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Bug in plan handling
I will have to check it. There is code to check duplicate alias, maybe there is bug . If the bug is valid, I am going to fix it in the next release

Thanks for reporting

Tuan

Please Log in or Create an account to join the conversation.